Return concrete classes from 'pyramid.httpexceptions.exception_response'.

Tres Seaver

2015-06-09 5d856debdac956dd1b3a4dd21feced52b2ce9279

Return concrete classes from 'pyramid.httpexceptions.exception_response'.

The base classes are not appropriate for ``400`` and ``500`` status codes.

See:  #1832

 CHANGES.txt

@@ -1,3 +1,9 @@
1.4.10 (unreleased)
===================

- Ensure that ``pyramid.httpexceptions.exception_response`` returns the
  appropriate "concreate" class for ``400`` and ``500`` status codes.

1.4.9 (2014-04-28)
==================


 pyramid/httpexceptions.py

@@ -553,13 +553,21 @@
    a bug.  A server-side traceback is not warranted.  Unless specialized,
    this is a '400 Bad Request'
    """
    pass

class HTTPBadRequest(HTTPClientError):
    """
    subclass of :class:`~HTTPClientError`

    This indicates that the request is malformed.

    code: 400, title: Bad Request
    """
    pass
    code = 400
    title = 'Bad Request'
    explanation = ('The server could not comply with the request since '
                   'it is either malformed or otherwise incorrect.')

class HTTPBadRequest(HTTPClientError):
    pass

class HTTPUnauthorized(HTTPClientError):
    """
@@ -911,14 +919,21 @@
    This is an error condition in which the server is presumed to be
    in-error.  Unless specialized, this is a '500 Internal Server Error'.
    """
    pass

class HTTPInternalServerError(HTTPServerError):
    """
    subclass of :class:`~HTTPServerError`

    This indicates that the application raised an unexpected exception.
    
    code: 500, title: Internal Server Error
    """
    code = 500
    title = 'Internal Server Error'
    explanation = (
      'The server has either erred or is incapable of performing '
      'the requested operation.')

class HTTPInternalServerError(HTTPServerError):
    pass

class HTTPNotImplemented(HTTPServerError):
    """

 pyramid/tests/test_httpexceptions.py

@@ -10,13 +10,22 @@
        from pyramid.httpexceptions import exception_response
        return exception_response(*arg, **kw)

    def test_status_400(self):
        from pyramid.httpexceptions import HTTPBadRequest
        self.assertTrue(isinstance(self._callFUT(400), HTTPBadRequest))

    def test_status_404(self):
        from pyramid.httpexceptions import HTTPNotFound
        self.assertEqual(self._callFUT(404).__class__, HTTPNotFound)
        self.assertTrue(isinstance(self._callFUT(404), HTTPNotFound))

    def test_status_500(self):
        from pyramid.httpexceptions import HTTPInternalServerError
        self.assertTrue(isinstance(self._callFUT(500),
                        HTTPInternalServerError))

    def test_status_201(self):
        from pyramid.httpexceptions import HTTPCreated
        self.assertEqual(self._callFUT(201).__class__, HTTPCreated)
        self.assertTrue(isinstance(self._callFUT(201), HTTPCreated))

    def test_extra_kw(self):
        resp = self._callFUT(404,  headers=[('abc', 'def')])