Chris McDonough
2011-01-23 877904ac1b192191b0bdac4f7e4e1cd6d5f27884
- The ``render_view`` method of ``pyramid.renderers.RendererHelper`` passed
an incorrect value into the renderer for ``renderer_info``. It now passes
an instance of ``RendererHelper`` instead of a dictionary, which is
consistent with other usages. See
https://github.com/Pylons/pyramid/issues#issue/106

Closes #106
3 files modified
26 ■■■■■ changed files
CHANGES.txt 6 ●●●●● patch | view | raw | blame | history
pyramid/renderers.py 2 ●●● patch | view | raw | blame | history
pyramid/tests/test_renderers.py 18 ●●●●● patch | view | raw | blame | history
CHANGES.txt
@@ -19,6 +19,12 @@
  start when ``paster serve development.ini`` was used against the result.
  See https://github.com/Pylons/pyramid/issues/#issue/107
- The ``render_view`` method of ``pyramid.renderers.RendererHelper`` passed
  an incorrect value into the renderer for ``renderer_info``.  It now passes
  an instance of ``RendererHelper`` instead of a dictionary, which is
  consistent with other usages.  See
  https://github.com/Pylons/pyramid/issues#issue/106
1.0b1 (2011-01-21)
==================
pyramid/renderers.py
@@ -286,7 +286,7 @@
        system = {
            'view':view,
            'renderer_name':self.name, # b/c
            'renderer_info':{'name':self.name, 'package':self.package},
            'renderer_info':self,
            'context':context,
            'request':request
            }
pyramid/tests/test_renderers.py
@@ -334,6 +334,24 @@
                                             request=request)
        self.assertEqual(response.body, ('values', 'system_values'))
    def test_render_view(self):
        self._registerRendererFactory()
        request = Dummy()
        helper = self._makeOne('loo.foo')
        view = 'view'
        context = 'context'
        request = testing.DummyRequest()
        response = 'response'
        response = helper.render_view(request, response, view, context)
        self.assertEqual(response.body,
                         ('response',
                          {'renderer_info': helper,
                           'renderer_name': 'loo.foo',
                           'request': request,
                           'context': 'context',
                           'view': 'view'})
                         )
    def test_render_explicit_registry(self):
        factory = self._registerRendererFactory()
        class DummyRegistry(object):