From 26446a92e043d107681f1bf9194621fe30731a04 Mon Sep 17 00:00:00 2001 From: Nicolas Sandron <nicolas.sandron@gmail.com> Date: Mon, 26 Mar 2018 12:36:18 +0200 Subject: [PATCH] Remove onTouchStart attribute when used together with onMouseDown --- test/__snapshots__/snapshots.spec.js.snap | 36 ++++++++++++------------------------ src/TimeView.js | 8 ++++---- 2 files changed, 16 insertions(+), 28 deletions(-) diff --git a/src/TimeView.js b/src/TimeView.js index 3e03740..89147d4 100644 --- a/src/TimeView.js +++ b/src/TimeView.js @@ -59,9 +59,9 @@ } } return React.createElement('div', { key: type, className: 'rdtCounter' }, [ - React.createElement('span', { key: 'up', className: 'rdtBtn', onTouchStart: this.onStartClicking('increase', type), onMouseDown: this.onStartClicking( 'increase', type ), onContextMenu: this.disableContextMenu }, '���' ), + React.createElement('span', { key: 'up', className: 'rdtBtn', onMouseDown: this.onStartClicking( 'increase', type ), onContextMenu: this.disableContextMenu }, '���' ), React.createElement('div', { key: 'c', className: 'rdtCount' }, value ), - React.createElement('span', { key: 'do', className: 'rdtBtn', onTouchStart: this.onStartClicking('decrease', type), onMouseDown: this.onStartClicking( 'decrease', type ), onContextMenu: this.disableContextMenu }, '���' ) + React.createElement('span', { key: 'do', className: 'rdtBtn', onMouseDown: this.onStartClicking( 'decrease', type ), onContextMenu: this.disableContextMenu }, '���' ) ]); } return ''; @@ -69,9 +69,9 @@ renderDayPart: function() { return React.createElement('div', { key: 'dayPart', className: 'rdtCounter' }, [ - React.createElement('span', { key: 'up', className: 'rdtBtn', onTouchStart: this.onStartClicking('toggleDayPart', 'hours'), onMouseDown: this.onStartClicking( 'toggleDayPart', 'hours'), onContextMenu: this.disableContextMenu }, '���' ), + React.createElement('span', { key: 'up', className: 'rdtBtn', onMouseDown: this.onStartClicking( 'toggleDayPart', 'hours'), onContextMenu: this.disableContextMenu }, '���' ), React.createElement('div', { key: this.state.daypart, className: 'rdtCount' }, this.state.daypart ), - React.createElement('span', { key: 'do', className: 'rdtBtn', onTouchStart: this.onStartClicking('toggleDayPart', 'hours'), onMouseDown: this.onStartClicking( 'toggleDayPart', 'hours'), onContextMenu: this.disableContextMenu }, '���' ) + React.createElement('span', { key: 'do', className: 'rdtBtn', onMouseDown: this.onStartClicking( 'toggleDayPart', 'hours'), onContextMenu: this.disableContextMenu }, '���' ) ]); }, diff --git a/test/__snapshots__/snapshots.spec.js.snap b/test/__snapshots__/snapshots.spec.js.snap index cdf5256..6561346 100644 --- a/test/__snapshots__/snapshots.spec.js.snap +++ b/test/__snapshots__/snapshots.spec.js.snap @@ -24,8 +24,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -35,8 +34,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> @@ -49,8 +47,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -60,8 +57,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> @@ -70,8 +66,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -81,8 +76,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> @@ -7635,8 +7629,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -7646,8 +7639,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> @@ -7660,8 +7652,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -7671,8 +7662,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> @@ -7681,8 +7671,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> <div @@ -7692,8 +7681,7 @@ <span className="rdtBtn" onContextMenu={[Function]} - onMouseDown={[Function]} - onTouchStart={[Function]}> + onMouseDown={[Function]}> ��� </span> </div> -- Gitblit v1.9.3