OCP4 : destroy action now starts every instances

Guillaume Coré

2018-12-18 1dc20e8fcc68adf8f9b5cb993ebd98553cf862d9

OCP4 : destroy action now starts every instances

Terraform destroy does not work if instances are stopped.

Make sure all instances are up, including the clientVM from where the
openshift-install command is run.

ec2-infra: include all instances, even stopped in the inventory. Exclude only
terminated.

 ansible/configs/ocp4-coreos-deployer/destroy_env.yml

@@ -18,6 +18,52 @@
          name: infra-common-ssh-config-generate
        when: "'bastions' in groups"

- name: Start clientVM and cluster instances if they are stopped
  hosts: localhost
  connection: local
  gather_facts: False
  become: no
  environment:
    AWS_ACCESS_KEY_ID: "{{aws_access_key_id}}"
    AWS_SECRET_ACCESS_KEY: "{{aws_secret_access_key}}"
    AWS_DEFAULT_REGION: "{{aws_region_final|d(aws_region)}}"
  tasks:
    - set_fact:
        clientvm_id: "{{ hostvars[groups.bastions[0]].instance_id }}"
      when:
        - "'bastions' in groups"
        - groups.bastions | length > 0

    - fail:
        msg: "No clientVM present"
      when: >-
        'bastions' not in groups or groups.bastions | length == 0

    - name: Start clientVM instance
      command: "aws ec2 start-instances --instance-ids '{{clientvm_id}}'"

    - name: Get cluster instance Ids
      command: >-
        aws ec2 describe-instances
        --filters "Name=tag:clusterid,Values=cluster-{{ guid }}"
        --query 'Reservations[*].Instances[*].InstanceId'
        --output text
      changed_when: false
      failed_when: instanceids.stdout | trim | length == 0
      register: instanceids

    - name: Start cluster instances
      command: >-
            aws ec2 start-instances --instance-ids {{ instanceids.stdout | trim }}

    - name: Wait for clientVM instance
      command: "aws ec2 wait instance-running --instance-ids '{{clientvm_id}}'"

    - name: Wait for cluster instances
      command: >-
            aws ec2 wait instance-running
            --filters "Name=tag:clusterid,Values=cluster-{{ guid }}"

- name: Destroy OCP 4 resources using the installer
  hosts: bastions
  gather_facts: false
@@ -29,6 +75,10 @@
        ansible_ssh_extra_args: >-
          {{ ansible_ssh_extra_args|d() }}
          -F {{hostvars.localhost.output_dir}}/{{ env_type }}_{{ guid }}_ssh_conf

    - name: wait for linux host to be available
      wait_for_connection:
        timeout: 20

    - name: Pack an archive of everything in case something goes wrong
      archive:
@@ -54,6 +104,8 @@
        src: /tmp/cluster-{{ guid }}.tar.gz
        dest: "{{ hostvars.localhost.output_dir }}/{{ env_type }}_{{ guid }}_cluster-{{ guid }}.tar.gz"

    - set_fact:
        oktodelete: yes

- name: Delete ocp4 provisioner stack
  hosts: localhost
@@ -64,3 +116,7 @@
    - name: Run infra-ec2-template-destroy
      include_role:
        name: infra-ec2-template-destroy
      when:
        - "'bastions' in groups"
        - groups.bastions | length > 0
        - hostvars[groups.bastions[0]].oktodelete

 ansible/configs/ocp4-coreos-deployer/files/install-config.yml.j2

@@ -19,7 +19,7 @@
  type: OpenshiftSDN
platform:
  aws:
    region: us-east-1
    region: {{ aws_region_final | d(aws_region) }}
    vpcCIDRBlock: 10.0.0.0/16
pullSecret: '{{ ocp4_token }}'
sshKey: |

 ansible/roles/infra-ec2-create-inventory/tasks/main.yml

@@ -9,7 +9,6 @@
    aws_secret_key: "{{ aws_secret_access_key }}"
    region: "{{ aws_region_final | default(aws_region) | default(region) | default('us-east-1')}}"
    filters:
      instance-state-name: running
      "tag:Project": "{{project_tag}}"
  register: ec2_facts
  tags:
@@ -60,6 +59,7 @@
    placement: "{{item['placement']['availability_zone']}}"
    image_id: "{{item['image_id']}}"
    ansible_ssh_extra_args: "-o StrictHostKeyChecking=no"
  when: item.state != 'terminated'
  with_items: "{{ec2_facts['instances']}}"
  loop_control:
    label: "{{item.tags.internaldns | default(item.private_dns_name)}}"
@@ -72,6 +72,7 @@
    name: "{{item.tags.internaldns | default(item.private_dns_name)}}"
    groups: "{{item.tags.AnsibleGroup}}"
  with_items: "{{ec2_facts['instances']}}"
  when: item.state != 'terminated'
  loop_control:
    label: "{{item.tags.internaldns | default(item.private_dns_name)}}"
  tags: